Feature/own http server #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver implementation and finished the custom http implementation. Added a JettyHTTPSocketServer as a backup option, but it doesn't support websockets.
Member
|
Is multipart form data already implemented? |
Member
Author
No, it's not yet implemented for the new server. Jetty is still usable in case you are worried about breaking changes. |
…it and there are reported issues with older versions
…t implementation for until the own implementation is fully stable.
Member
Author
|
I've changed it back to using jetty as the default until the own implementation is stable enough to be used for any production case. I've also upgraded to the current jetty version. The upgrade was blocked by the hacky websocket implementation before that has now been removed. |
Member
Author
|
this also closes #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an own http server from ground up and abstracts the http server logic from the framework logic so http server implementations are interchangeable. By default the new SimpleHTTPSocketServer will be used but currently there is also a JettyHTTPSocketServer that can be used optionally if something doesn't yet work with the simple implementation. This should removed or moved to a seperate repository so jetty can be removed from the dependencies. The websocket logic is also reimplemented with our own websocket handling instead of the hacky jetty implementation that was previously used. Unfortunately jetty doesn't fully conform to the Java EE standard so it doesn't allow upgrading the connection by yourself and therefore websockets are only working with the simple implementation. I tried several things to hijack the jetty connection but wasn't successful.